> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, September 04, 2014 12:18 PM > > On Thu, Sep 04, 2014 at 12:04:23PM -0700, Paul Zimmerman wrote: > > From: Kamil Debski <k.deb...@samsung.com> > > > > When the driver is removed s3c_hsotg_phy_disable is called three times > > instead of once. This results in decreasing of the phy reference counter > > below zero and thus consecutive inserts of the module fails. > > > > This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove > > and s3c_hsotg_udc_stop. > > > > s3c_hsotg_udc_stop is called from udc-core.c only after > > usb_gadget_disconnect, which in turn calls s3c_hsotg_pullup, which > > already calls s3c_hsotg_phy_disable. > > > > s3c_hsotg_remove must be called only after udc_stop, so there is no > > point in disabling phy once again there. > > > > Signed-off-by: Kamil Debski <k.deb...@samsung.com> > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > > Signed-off-by: Robert Baldyga <r.bald...@samsung.com> > > Signed-off-by: Paul Zimmerman <pa...@synopsys.com> > > looks like this one deserves a Cc: stable ?
Good point. Robert, what do you think? Only problem is, this file moved from drivers/usb/gadget/ to here in 3.16, so earlier stable versions would require some additional backporting. -- Paul > FWIW > > Reviewed-by: Felipe Balbi <ba...@ti.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
