On 7/1/2014 12:01 AM, Felipe Balbi wrote:
Hi,

On Mon, Jun 09, 2014 at 10:44:38AM +0530, Amit Virdi wrote:
Felipe, Alan,

On 5/23/2014 12:01 PM, Amit VIRDI wrote:
This patchset adds support for interrupt EP and the corresponding test cases to
gadget zero. The code has been rebased and tested on Kernel v3.15-rc5

V2 -> V3
  - Rectified wMaxPacketSize for FS from 1023 to 64
  - Modified default value of interrupt interval for FS to 1 ms

V1 -> V2
  - Modified the alternate interface from having 6 EPs (2 - Interrupt, 2 Bulk, 2
    Isoc) to 2 EPs (Interrupt only)

RFC -> V1
  - Added support for configuring interrupt EP attributes from configfs 
interface

Amit Virdi (2):
   usb: gadget: zero: Add support for interrupt EP
   usbtest: Add interrupt EP testcases


Any comment on this patchset?

can you send some logs of this patchset working ? What output should we
expect ? How to run it ?

(sure, we could just read the source code and figure it out, but it's
good 'documentation' to put on the commit log)


In case the newly added tests pass, there's no log that the test passed (although kernel reports that it is going to execute the Test#). This has been the convention followed in the usbtest.c for all other tests as well.

But surely, I can document how to execute the new tests and what to expect for failure scenarios.

I'll rebase the patchset on latest kernel version, and re-send with modified commit logs.

Regards
Amit Virdi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to