From: Pratyush Anand <pratyush.an...@st.com>

When a USB device is disconnected, usb_unbind_interface is called, which
tries to enable and disable LPM. usb_enable_lpm also try to send a
control command SET SEL to the device.
Since device is already disconnected, therefore it does not make sense
to execute usb_(en/dis)able_lpm.
This patch returns from usb_(en/dis)able_lpm, if device was not in
default state atleast.

Signed-off-by: Pratyush Anand <pratyush.an...@st.com>
Tested-by: Aymen Bouattay <aymen.bouat...@st.com>
Signed-off-by: Mathias Nyman <mathias.ny...@linux.intel.com>
---
 drivers/usb/core/hub.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 879b66e..9c469dc 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3853,7 +3853,8 @@ int usb_disable_lpm(struct usb_device *udev)
 
        if (!udev || !udev->parent ||
                        udev->speed != USB_SPEED_SUPER ||
-                       !udev->lpm_capable)
+                       !udev->lpm_capable ||
+                       udev->state < USB_STATE_DEFAULT)
                return 0;
 
        hcd = bus_to_hcd(udev->bus);
@@ -3909,7 +3910,8 @@ void usb_enable_lpm(struct usb_device *udev)
 
        if (!udev || !udev->parent ||
                        udev->speed != USB_SPEED_SUPER ||
-                       !udev->lpm_capable)
+                       !udev->lpm_capable ||
+                       udev->state < USB_STATE_DEFAULT)
                return;
 
        udev->lpm_disable_count--;
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to