> -----Original Message-----
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of philippedesw...@gmail.com
> Sent: Saturday, May 24, 2014 7:29 PM
> To: philippedesw...@gmail.com; linux-usb@vger.kernel.org
> Subject: [PATCH v3 2/4] libusbg: Fix buffer overrun issue.
> CID#56128
>
> From: Philippe De Swert <philippe.desw...@jollamobile.com>
>
> Avoid calling usbg_read_string() with a 40 byte long buffer, which
> in turn is filled in
> by usbg_read_buf() which uses a maximum of 256 bytes
> (USBG_MAX_STR_LENGTH). This adjusts
> the buffer to be the right size.
>
> Signed-off-by: Philippe De Swert <philippe.desw...@jollamobile.com>
Reviewed-by: Krzysztof Opasiak <k.opas...@samsung.com>
> ---
> src/usbg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/usbg.c b/src/usbg.c
> index 5d9c083..66aa435 100644
> --- a/src/usbg.c
> +++ b/src/usbg.c
> @@ -681,7 +681,7 @@ static int
> usbg_parse_function_net_attrs(usbg_function *f,
> usbg_function_attrs *f_attrs)
> {
> struct ether_addr *addr;
> - char str_addr[40];
> + char str_addr[USBG_MAX_STR_LENGTH];
> int ret;
>
> ret = usbg_read_string(f->path, f->name, "dev_addr",
> str_addr);
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
