[PATCH 1/2] usb: dwc3: no need to initialize ret variable

[Andy Shevchenko]

First usage of ret variable will re-write initial value. Thus, there is no need
to initialize it.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
 drivers/usb/dwc3/core.c        |  2 +-
 drivers/usb/dwc3/dwc3-exynos.c | 12 +++++-------
 drivers/usb/dwc3/dwc3-omap.c   |  2 +-
 drivers/usb/dwc3/dwc3-pci.c    |  2 +-
 drivers/usb/dwc3/gadget.c      |  2 +-
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 0d1895a..eb69eb9 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -626,7 +626,7 @@ static int dwc3_probe(struct platform_device *pdev)
        struct resource         *res;
        struct dwc3             *dwc;
 
-       int                     ret = -ENOMEM;
+       int                     ret;
 
        void __iomem            *regs;
        void                    *mem;
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 0ed8583..f9fb8ad 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -110,12 +110,12 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
        struct device           *dev = &pdev->dev;
        struct device_node      *node = dev->of_node;
 
-       int                     ret = -ENOMEM;
+       int                     ret;
 
        exynos = devm_kzalloc(dev, sizeof(*exynos), GFP_KERNEL);
        if (!exynos) {
                dev_err(dev, "not enough memory\n");
-               goto err1;
+               return -ENOMEM;
        }
 
        /*
@@ -125,21 +125,20 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
         */
        ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
        if (ret)
-               goto err1;
+               return ret;
 
        platform_set_drvdata(pdev, exynos);
 
        ret = dwc3_exynos_register_phys(exynos);
        if (ret) {
                dev_err(dev, "couldn't register PHYs\n");
-               goto err1;
+               return ret;
        }
 
        clk = devm_clk_get(dev, "usbdrd30");
        if (IS_ERR(clk)) {
                dev_err(dev, "couldn't get clock\n");
-               ret = -EINVAL;
-               goto err1;
+               return -EINVAL;
        }
 
        exynos->dev     = dev;
@@ -189,7 +188,6 @@ err3:
        regulator_disable(exynos->vdd33);
 err2:
        clk_disable_unprepare(clk);
-err1:
        return ret;
 }
 
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 1160ff4..4af4c35 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -393,7 +393,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        struct extcon_dev       *edev;
        struct regulator        *vbus_reg = NULL;
 
-       int                     ret = -ENOMEM;
+       int                     ret;
        int                     irq;
 
        int                     utmi_mode = 0;
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 1ed95e0..e76d1ca 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -99,7 +99,7 @@ static int dwc3_pci_probe(struct pci_dev *pci,
        struct resource         res[2];
        struct platform_device  *dwc3;
        struct dwc3_pci         *glue;
-       int                     ret = -ENOMEM;
+       int                     ret;
        struct device           *dev = &pci->dev;
 
        glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 54da8c8..9d64dd0 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -580,7 +580,7 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep *dep,
 {
        struct dwc3             *dwc = dep->dwc;
        u32                     reg;
-       int                     ret = -ENOMEM;
+       int                     ret;
 
        dev_vdbg(dwc->dev, "Enabling %s\n", dep->name);
 
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html