On Wed, 2014-03-19 at 23:04 +0100, Cédric Cabessa wrote:
[]
> diff --git a/drivers/staging/usbip/usbip_common.c 
> b/drivers/staging/usbip/usbip_common.c
[]
> @@ -178,8 +178,8 @@ static void usbip_dump_usb_ctrlrequest(struct 
> usb_ctrlrequest *cmd)
>       }
>  
>       pr_debug("       ");
> -     pr_debug("bRequestType(%02X) bRequest(%02X) wValue(%04X) wIndex(%04X) "
> -              "wLength(%04X) ", cmd->bRequestType, cmd->bRequest,
> +     pr_debug("bRequestType(%02X) bRequest(%02X) wValue(%04X) wIndex(%04X) 
> wLength(%04X) ",
> +              cmd->bRequestType, cmd->bRequest,
>                cmd->wValue, cmd->wIndex, cmd->wLength);
>       pr_debug("\n       ");

While you didn't change it, these uses are broken.

pr_debug always starts a new line so the continuations
attempted in this block don't work.

Likely this was originally converted from some non pr_debug
mechanism without an understanding of how pr_debug varies
from a normal printf.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to