On Sat, Oct 26, 2013 at 08:41:53PM -0700, Joe Perches wrote: > pr_debug_ratelimited should be coded similarly to dev_dbg_ratelimited > to reduce the "callbacks suppressed" messages. > > Add #include <linux/dynamic_debug.h> to printk.h. Unfortunately, this > new #include must be after the prototype/declaration of function printk. > > It may be better to split out these _ratelimited declarations into > a separate file one day. > > Any use of these pr_<foo>_ratelimited functions must also have another > specific #include <ratelimited.h>. Most users have this done indirectly > via #include <linux/kernel.h> > > printk.h may not #include <linux/ratelimit.h> as it causes circular > dependencies and compilation failures. > > Signed-off-by: Joe Perches <j...@perches.com> > --- > V2: Fix #include dependencies and typos. > > Compile tested with and without CONFIG_DYNAMIC_DEBUG
I've tested both patches without CONFIG_DYNAMIC_DEBUG and with enabled and disabled debugging with CONFIG_DYNAMIC_DEBUG and everything seems work correctly. Thanks, Krzysiek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
