On Thu, Oct 03, 2013 at 10:11:36AM -0400, Alan Stern wrote:
> On Thu, 3 Oct 2013, Huang Rui wrote:
>
> > +int usb_amd_hang_symptom_quirk(void)
> > +{
> > + u8 rev;
> > +
> > + usb_amd_find_chipset_info();
> > + rev = amd_chipset.sb_type.rev;
> > + /* SB600 and old version of SB700 have hang symptom bug */
> > + return (amd_chipset.sb_type.gen == AMD_CHIPSET_SB600 ||
> > + (amd_chipset.sb_type.gen == AMD_CHIPSET_SB700 &&
> > + rev >= 0x3a && rev <= 0x3b)) ? 1 : 0;
>
> You don't need the "? 1 : 0" part. When you remove it, change the
> function's return type to bool. The same comment applies to the other
> patch in this series.
>
Thank you, will update.
Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
