On Mon, Jul 08, 2013 at 07:43:30PM -0600, Anthony Foiani wrote:
> Anthony Foiani <anthony.foi...@gmail.com> writes:
> 
> > Introduce option "-P" / "--pid" to request that usbipd save its PID to
> > a file while running.
> 
> I've already spotted one problem with this patch:
> 
> > +           write_pid_file(pid_file);
> >             rc = do_standalone_mode(daemonize);
> > +           remove_pid_file(pid_file);
> 
> I need to write the PID *after* the daemon(3) call.  (I suspect I did
> all my testing in foreground mode, so didn't notice this until I
> actually tried to use it on my project...)
> 
> So there will be a v2, but I'll probably wait for more feedback before
> doing an official respin.

I've applied the first 3 patches, as they seemed simple enough :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to