Alan Stern wrote:
> On Sat, 20 Jul 2013, Mariusz Grecki wrote:
>> +    u16 buf = 1;
>> +
>> +    snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 0x2a,
>> +                    USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER,
>> +                    0, 0, &buf, 2);
>
> There's a serious problem here.  It's present in most or all of the
> quirk routines in this file, not just yours.
>
> Namely, buffers used for USB transfers must not be allocated on the
> stack; they must be allocated using kmalloc or a related function.

This is what snd_usb_ctl_msg() does.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to