[PATCH] usb: phy: phy-mxs-usb: Check the return value from stmp_reset_block()

[Fabio Estevam]

From: Fabio Estevam <fabio.este...@freescale.com>

stmp_reset_block() may fail, so let's check its return value and propagate it in
the case of error.

Signed-off-by: Fabio Estevam <fabio.este...@freescale.com>
---
 drivers/usb/phy/phy-mxs-usb.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index bd601c5..fdd33b4 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -41,11 +41,14 @@ struct mxs_phy {
 
 #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy)
 
-static void mxs_phy_hw_init(struct mxs_phy *mxs_phy)
+static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
 {
+       int ret;
        void __iomem *base = mxs_phy->phy.io_priv;
 
-       stmp_reset_block(base + HW_USBPHY_CTRL);
+       ret = stmp_reset_block(base + HW_USBPHY_CTRL);
+       if (ret)
+               return ret;
 
        /* Power up the PHY */
        writel(0, base + HW_USBPHY_PWD);
@@ -54,6 +57,8 @@ static void mxs_phy_hw_init(struct mxs_phy *mxs_phy)
        writel(BM_USBPHY_CTRL_ENUTMILEVEL2 |
               BM_USBPHY_CTRL_ENUTMILEVEL3,
               base + HW_USBPHY_CTRL_SET);
+
+       return 0;
 }
 
 static int mxs_phy_init(struct usb_phy *phy)
@@ -61,9 +66,7 @@ static int mxs_phy_init(struct usb_phy *phy)
        struct mxs_phy *mxs_phy = to_mxs_phy(phy);
 
        clk_prepare_enable(mxs_phy->clk);
-       mxs_phy_hw_init(mxs_phy);
-
-       return 0;
+       return mxs_phy_hw_init(mxs_phy);
 }
 
 static void mxs_phy_shutdown(struct usb_phy *phy)
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html