On 07/02/2013 10:26 AM, Felipe Balbi wrote:
> alright, how about this ? I'll split dr_mode documentation to a
> separate patch soon and resend with devicetree-discuss in the
> loop.

Okay.

> diff --git a/Documentation/devicetree/bindings/usb/generic.txt
> b/Documentation/devicetree/bindings/usb/generic.txt new file mode
> 100644 index 0000000..623e360 --- /dev/null +++
> b/Documentation/devicetree/bindings/usb/generic.txt @@ -0,0 +1,25
> @@ +Generic USB Properties + +Optional properties: + -
> maximum-speed: tells USB controllers we want to work up to a
> certain +                     speed. Valid arguments are "super-speed",
> "high-speed", +                       "full-speed" and "low-speed". In case 
> this isn't
> passed +                      via DT, USB controllers should default to their 
> maximum 
> +                     HW capability. + - dr_mode: tells Dual-Role USB 
> controllers
> that we want to work on a +                   particular mode. Valid 
> arguments are
> "host", +                     "peripheral" and "otg". In case this attribute 
> isn't +
> passed via DT, USB DRD controllers should default to +                        
> OTG. + 
> +This is an attribute to a USB controller such as: + +dwc3@4a030000
> { +   compatible = "synopsys,dwc3"; + reg = <0x4a030000 0xcfff>; +
> interrupts = <0 92 4> +       usb-phy = <&usb2_phy>, <&usb3,phy>;

Two things:
- we seem to use usb-phy and phys. Couldn't we just stick to one?
- usb-phy is optional, isn't it?

> +     tx-fifo-resize;
this one is dwc3 specific right? The other two (max speed & dr_mode)
look generic enough.

> +     maximum-speed = "super-speed"; +        dr_mode = "otg"; +};

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to