Hi, On Thu, Jun 20, 2013 at 01:53:13PM +0000, Yuan-Hsin Chen wrote: > Because fotg210-udc is configured as a non-hotpluggable device, > that makes sense to use module_platform_driver_probe() instead of > module_platform_driver(). This also fixes the section mismatch issue. > > Signed-off-by: Yuan-Hsin Chen <yhc...@faraday-tech.com>
I would rather see you remove __init annotation from your probe() function. The reason being that it will users to bind/unbind the driver through sysfs, which is pretty good for testing, at least. -- balbi
signature.asc
Description: Digital signature
