On Thu, 25 Apr 2013, Yuan-Hsin Chen wrote: > Hi, > > Are there any comments?
This is okay. There's just one thing... > On Tue, Apr 16, 2013 at 8:43 PM, Yuan-Hsin Chen <yuan...@gmail.com> wrote: > > > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200. > > FUSBH200 is an ehci-like controller with some differences. > > First, register layout of FUSBH200 is incompatible with EHCI. > > Furthermore, FUSBH200 is lack of siTDs which means iTDs > > are used for both HS and FS ISO transfer. > > > > Signed-off-by: Yuan-Hsin Chen <yhc...@faraday-tech.com> > > --- > > > > v2: > > use ehci-platform.c > > use anonymous union and struct > > add is_fusbh200 to struct ehci_hcd > > > > v3: > > duplicate most of code from Linux-3.8 ehci hcd > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -287,6 +287,14 @@ config USB_ISP1362_HCD > > To compile this driver as a module, choose M here: the > > module will be called isp1362-hcd. > > > > +config USB_FUSBH200_HCD > > + bool "Faraday FUSBH200 HCD support" Shouldn't this be tristate? > > + depends on USB > > + default N > > + ---help--- > > + The USB HCD Driver of Faraday FUSBH200 is designed to > > + meet USB2.0 EHCI specification with minor modification > > + Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
