> From: Matthijs Kooijman [mailto:matth...@stdin.nl]
> Sent: Monday, April 15, 2013 7:14 AM
> 
> This function disables all "common interrupts", i.e., those that are
> handled by the common interrupt handler.
> 
> Signed-off-by: Matthijs Kooijman <matth...@stdin.nl>
> ---
>  drivers/staging/dwc2/core.c      | 14 ++++++++++++++
>  drivers/staging/dwc2/core.h      |  6 ++++++
>  drivers/staging/dwc2/core_intr.c |  5 -----
>  3 files changed, 20 insertions(+), 5 deletions(-)

...

> diff --git a/drivers/staging/dwc2/core.h b/drivers/staging/dwc2/core.h
> index cc2f360..a243615 100644
> --- a/drivers/staging/dwc2/core.h
> +++ b/drivers/staging/dwc2/core.h
> @@ -452,6 +452,7 @@ extern void dwc2_flush_rx_fifo(struct dwc2_hsotg *hsotg);
>  extern int dwc2_core_init(struct dwc2_hsotg *hsotg, bool select_phy, int 
> irq);
>  extern void dwc2_enable_global_interrupts(struct dwc2_hsotg *hcd);
>  extern void dwc2_disable_global_interrupts(struct dwc2_hsotg *hcd);
> +extern void dwc2_disable_common_interrupts(struct dwc2_hsotg *hsotg);
> 
>  /* This function should be called on every hardware interrupt. */
>  extern irqreturn_t dwc2_handle_common_intr(int irq, void *dev);
> @@ -663,4 +664,9 @@ extern u16 dwc2_get_otg_version(struct dwc2_hsotg *hsotg);
>                        GINTSTS_I2CINT | GINTSTS_PRTINT | GINTSTS_HCHINT | \
>                        GINTSTS_PTXFEMP)
> 
> +#define GINTMSK_COMMON       (GINTSTS_WKUPINT | GINTSTS_SESSREQINT | \
> +                      GINTSTS_CONIDSTSCHNG | GINTSTS_OTGINT | \
> +                      GINTSTS_MODEMIS | GINTSTS_DISCONNINT | \
> +                      GINTSTS_USBSUSP | GINTSTS_RESTOREDONE)
> +

This list of interrupts needs to change according to my comments for
patch 3/10. Once that is done, you can add my acked-by.

BTW, the same thing applies to patch 5/10, so I guess I prematurely
acked that one. So I take my ack back :) for that one until the list
of interrupts is changed there too.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to