On Tue, Mar 12, 2013 at 11:46:49AM +0200, Felipe Balbi wrote:
> On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote:
> > Let the common struct usb_gadget own it.
> >
> > CC: Alexander Shishkin <alexander.shish...@linux.intel.com>
> > CC: Jean-Christophe PLAGNIOL-VILLARD <plagn...@jcrosoft.com>
> > CC: Li Yang <le...@freescale.com>
> > CC: Roland Stigge <sti...@antcom.de>
> > CC: Yu Xu <y...@marvell.com>
> > CC: Chao Xie <chao....@marvell.com>
> > CC: Eric Miao <eric.y.m...@gmail.com>
> > CC: Ben Dooks <ben-li...@fluff.org>
> > Signed-off-by: Peter Chen <peter.c...@freescale.com>
>
> you need to split this patch, should be something like below:
>
> for_each_driver() {
> initialize gadget->vbus_active (don't remove private method)
> }
>
> add vbus_active support to udc-core
>
> for_each_driver() {
> remove driver's private vbus_active method
> }
>
> you need one patch per driver so it's easy to review and ack.
Eg, If I changed 10 udc drivers, I need
1(add vbus_active to struct usb_gadget) + 10 + 1 + 10 = 22 patches?
>
> --
> balbi
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
