Dear Greg: > -----Original Message----- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, January 19, 2013 7:42 AM > To: Fangxiaozhi (Franko) > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying > (Zihan); > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); > ba...@ti.com; > mdharm-...@one-eyed-alien.net; sebast...@breakpoint.cc > Subject: Re: USB: storage: optimize the matching rules and support new switch > command for Huawei USB storage devices > > On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote: > > > > From: fangxiaozhi <huana...@huawei.com> > > > > 1. Optimize the matching rules with new macro for Huawei USB storage > > devices, to avoid to load USB storage driver for the modem interface > > with Huawei devices. > > 2. Add to support new switch command for new Huawei USB dongles. > > > > Signed-off-by: fangxiaozhi <huana...@huawei.com> > > Next time, please always use the scripts/checkpatch.pl tool to find any > problems you might have made in your patch (you had trailing whitespace in > this one, which I have fixed.) > -----Yes, I have checked my patch with scripts/checkpatch.pl tool before submitting. -----For this trailing whitespace error, I think that it is better readable to leave whitespace in our patch code. Isn't it?
> Also, you might want to use git, it makes creating the patches easier, that > way > you don't end up with lines in the patch like this one: > > > Binary files linux-3.8-rc3_orig/drivers/usb/storage/initializers.o and > > linux-3.8-rc3/drivers/usb/storage/initializers.o differ > > thanks, > > greg k-h Best Regards, Franko Fang
