Hi, claus.stovga...@gmail.com wrote: > On man, 2019-07-01 at 20:48 +0000, Thinh Nguyen wrote: >> Hi, >> >> >>> ---- >>> reg = dwc3_readl(dwc->regs, DWC3_DCTL); >>> if (reg & DWC3_DCTL_INITU2ENA) >>> param = dwc->u2pel; >>> if (reg & DWC3_DCTL_INITU1ENA) >>> param = dwc->u1pel; >> This is incorrect. If the controller is enabled for both U1 and U2, >> then >> periodic param is U2PEL. If the controller is only enabled for U1, >> then >> U1PEL is used. Probably the original author intended but missed the >> "else" on the second if case. >> >> >> According to the databook, currently the controller doesn't use these >> programmed values. It uses the value from CoreConsultant >> configuration >> setting. >> > Thanks for your quick reply. > > So my understanding from your message is that the code is wrong, and I > was correct in being puzzled. Though the core currently does not use > the values, so currently the code is unimportant as it is unused by the > hardware. >
Right. Even though currently it does not affect the controller, the code needs to be fixed along with some note that the controller currently doesn't use these values. BR, Thinh
