> Changes from v3->v4: > - Further refactor master_xfer based on Wolfram's comment.
Yay, looks even better. One thing to improve, though.
> status = gpu_i2c_stop(i2cd);
send_stop = false;
> - if (status < 0)
> - return status;
> + if (status < 0) {
> + send_stop = false;
and skip it here...
> + goto exit;
> + }
>
> - return i;
> -stop:
> - status2 = gpu_i2c_stop(i2cd);
> - if (status2 < 0)
> - dev_err(i2cd->dev, "i2c stop failed %d\n", status2);
> + send_stop = false;
... and here.
signature.asc
Description: PGP signature
