Hi Chris,
On Tue, May 14, 2019 at 4:58 PM Chris Brandt <chris.bra...@renesas.com> wrote:
> Enable USB Host support for both the Type-C connector on the CPU board
> and the Type-A plug on the sub board.
>
> Both boards are also capable of USB Device operation as well after the
> appropriate Device Tree modifications.
>
> Signed-off-by: Chris Brandt <chris.bra...@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
One question below.
> --- a/arch/arm/boot/dts/r7s9210-rza2mevb.dts
> +++ b/arch/arm/boot/dts/r7s9210-rza2mevb.dts
> @@ -161,3 +173,28 @@
> bus-width = <4>;
> status = "okay";
> };
> +
> +/* USB-0 as Host */
> +/* NOTE: Requires JP3 to be fitted */
This not applies to the dr_mode property below, right?
So perhaps it should be moved there...
> +&usb2_phy0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_pins>;
> + dr_mode = "host";
... like:
dr_mode = "host"; /* Requires JP3 to be fitted */
Does resistor R78 need to be mounted, too?
> + status = "okay";
> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
