On Tue, Apr 16, 2019 at 12:45:12AM +0000, Ajay Gupta wrote:
> Hi Heikki,
> 
> > -----Original Message-----
> > From: linux-usb-ow...@vger.kernel.org <linux-usb-ow...@vger.kernel.org> On
> > Behalf Of Heikki Krogerus
> > Sent: Monday, April 15, 2019 5:10 AM
> > To: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > Cc: Ajay Gupta <aj...@nvidia.com>; linux-usb@vger.kernel.org
> > Subject: [PATCH v2 6/7] usb: typec: displayport: Export probe and remove
> > functions
> > 
> > From: Ajay Gupta <aj...@nvidia.com>
> > 
> > VirtualLink standard extends the DisplayPort Alt Mode by utilizing also the 
> > USB 2
> > pins on the USB Type-C connector.
> > It uses the same messages as DisplayPort, but not the DP SVID. At the time 
> > of
> > writing, USB IF has not assigned a Standard ID (SID) for VirtualLink, so the
> > manufacturers of VirtualLink adapters use their Vendor IDs as the SVID.
> > 
> > Since the SVID specific communication is exactly the same as with 
> > DisplayPort
> > alternate mode, there is no need to implement separate driver for 
> > VirtualLink.
> > We'll handle the current VirtualLink adapters with probe drivers, and once 
> > there
> > is SVID assigned for it, we add it to the displayport alt mode driver.
> > 
> > To support probing drivers, exporting the probe and remove functions, and 
> > also
> > changing the DP_HEADER helper macro to use the SVID of the alternate mode
> > device instead of the DisplayPort alt mode SVID.
> > 
> > Suggested-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
> > Signed-off-by: Ajay Gupta <aj...@nvidia.com>
> > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
> > ---
> >  drivers/usb/typec/altmodes/displayport.c | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> Looks like you missed adding displayport.h file. It is available in original 
> patch below,
>  https://marc.info/?l=linux-usb&m=155492587224379&w=2 

That's the one I picked, and I did compile the driver as well.. I'm
not sure what I've done, but I'll resend the series.

Sorry for the hassle.

thanks,

-- 
heikki

Reply via email to