On 13.02.2019 10:45, Heikki Krogerus wrote:

When the connections are defined in firmware, struct
device_connection will have the fwnode member pointing to
the device node (struct fwnode_handle) of the requested
device, and the endpoint will not be used at all in that
case.

Acked-by: Hans de Goede <hdego...@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
Reviewed-by: Jun Li <jun...@nxp.com>
Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
---
  drivers/usb/typec/class.c | 24 +++++++++++++++++++++---
  1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 45abe2c7e9f3..2eb623841847 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
[...]
+       /*
+        * FIXME: Check does the fwnode supports the requested SVID. If it does

   Perhaps "check if the fwnode supports"? Or at least s/supports/support/...

[...]

MBR, Sergei

Reply via email to