Now that buffer size is always passed around, we don't need to rely on
strcat anymore.

Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com>
---
 drivers/usb/dwc3/debug.h | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h
index e925a6b73005..6759a7efd8d5 100644
--- a/drivers/usb/dwc3/debug.h
+++ b/drivers/usb/dwc3/debug.h
@@ -545,21 +545,25 @@ static inline const char *dwc3_ep_event_string(char *str, 
size_t size,
                                status & DEPEVT_STATUS_TRANSFER_ACTIVE ?
                                " (Active)" : " (Not Active)");
 
+               len = strlen(str);
+
                /* Control Endpoints */
                if (epnum <= 1) {
                        int phase = DEPEVT_STATUS_CONTROL_PHASE(event->status);
 
                        switch (phase) {
                        case DEPEVT_STATUS_CONTROL_DATA:
-                               strcat(str, " [Data Phase]");
+                               snprintf(str + ret, size - ret,
+                                               " [Data Phase]");
                                break;
                        case DEPEVT_STATUS_CONTROL_STATUS:
-                               strcat(str, " [Status Phase]");
+                               snprintf(str + ret, size - ret,
+                                               " [Status Phase]");
                        }
                }
                break;
        case DWC3_DEPEVT_RXTXFIFOEVT:
-               strcat(str, "FIFO");
+               snprintf(str + ret, size - ret, "FIFO");
                break;
        case DWC3_DEPEVT_STREAMEVT:
                status = event->status;
@@ -571,13 +575,13 @@ static inline const char *dwc3_ep_event_string(char *str, 
size_t size,
                        break;
                case DEPEVT_STREAMEVT_NOTFOUND:
                default:
-                       strcat(str, " Stream Not Found");
+                       snprintf(str + ret, size - ret, " Stream Not Found");
                        break;
                }
 
                break;
        case DWC3_DEPEVT_EPCMDCMPLT:
-               strcat(str, "Endpoint Command Complete");
+               snprintf(str + ret, size - ret, "Endpoint Command Complete");
                break;
        default:
                snprintf(str, size, "UNKNOWN");
-- 
2.20.1

Reply via email to