On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > Move Synopsys HAPS platform device IDs to pci_ids.h. > > Signed-off-by: Thinh Nguyen <thi...@synopsys.com>
1) Run "git log --oneline include/linux/pci_ids.h" and follow the style convention for patch subject. 2) Explain in the changelog why we're moving this to pci_ids.h. Note the comment at the top of pci_ids.h. I think the move is fine because you're using the definition in two places, so just mention that in the changelog. Thanks! > --- > drivers/usb/dwc3/dwc3-haps.c | 4 ---- > include/linux/pci_ids.h | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c > index c9cc33881bef..02d57d98ef9b 100644 > --- a/drivers/usb/dwc3/dwc3-haps.c > +++ b/drivers/usb/dwc3/dwc3-haps.c > @@ -15,10 +15,6 @@ > #include <linux/platform_device.h> > #include <linux/property.h> > > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > - > /** > * struct dwc3_haps - Driver private structure > * @dwc3: child dwc3 platform_device > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d157983b84cf..c48550aa67e3 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2354,6 +2354,9 @@ > #define PCI_DEVICE_ID_CENATEK_IDE 0x0001 > > #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > > #define PCI_VENDOR_ID_VITESSE 0x1725 > #define PCI_DEVICE_ID_VITESSE_VSC7174 0x7174 > -- > 2.11.0 >
