Hi Matthew, Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.20-rc4 next-20181130] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Starr/usb-chipidea-imx-Allow-OC-polarity-active-low/20181202-132847 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: x86_64-randconfig-x000-201848 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/usb/chipidea/usbmisc_imx.c: In function 'usbmisc_imx7d_init': >> drivers/usb/chipidea/usbmisc_imx.c:452:2: error: expected '}' before 'else' else { ^~~~ vim +452 drivers/usb/chipidea/usbmisc_imx.c 434 435 static int usbmisc_imx7d_init(struct imx_usbmisc_data *data) 436 { 437 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev); 438 unsigned long flags; 439 u32 reg; 440 441 if (data->index >= 1) 442 return -EINVAL; 443 444 spin_lock_irqsave(&usbmisc->lock, flags); 445 reg = readl(usbmisc->base); 446 if (data->disable_oc) { 447 reg |= MX6_BM_OVER_CUR_DIS; 448 } else if (data->oc_polarity == 1) { 449 /* Low active */ 450 reg &= ~(MX6_BM_OVER_CUR_DIS); 451 reg |= MX6_BM_OVER_CUR_POLARITY; > 452 else { 453 reg &= ~(MX6_BM_OVER_CUR_DIS | MX6_BM_OVER_CUR_POLARITY); 454 } 455 writel(reg, usbmisc->base); 456 457 reg = readl(usbmisc->base + MX7D_USBNC_USB_CTRL2); 458 reg &= ~MX7D_USB_VBUS_WAKEUP_SOURCE_MASK; 459 writel(reg | MX7D_USB_VBUS_WAKEUP_SOURCE_BVALID, 460 usbmisc->base + MX7D_USBNC_USB_CTRL2); 461 spin_unlock_irqrestore(&usbmisc->lock, flags); 462 463 usbmisc_imx7d_set_wakeup(data, false); 464 465 return 0; 466 } 467 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
