[PATCH] usb: cast sizeof() to int when comparing with error code

[Chengguang Xu]

Negative error code will be larger than sizeof().

Signed-off-by: Chengguang Xu <cgxu...@gmx.com>
---
 drivers/usb/serial/ir-usb.c   | 2 +-
 drivers/usb/serial/quatech2.c | 2 +-
 drivers/usb/serial/ssu100.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c
index 24b06c7e5e2d..7643716b5299 100644
--- a/drivers/usb/serial/ir-usb.c
+++ b/drivers/usb/serial/ir-usb.c
@@ -132,7 +132,7 @@ irda_usb_find_class_desc(struct usb_serial *serial, 
unsigned int ifnum)
                        0, ifnum, desc, sizeof(*desc), 1000);
 
        dev_dbg(&serial->dev->dev, "%s -  ret=%d\n", __func__, ret);
-       if (ret < sizeof(*desc)) {
+       if (ret < (int)sizeof(*desc)) {
                dev_dbg(&serial->dev->dev,
                        "%s - class descriptor read %s (%d)\n", __func__,
                        (ret < 0) ? "failed" : "too short", ret);
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 958e12e1e7c7..ff2322ea5e14 100644
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -194,7 +194,7 @@ static inline int qt2_getregister(struct usb_device *dev,
        ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
                              QT_SET_GET_REGISTER, 0xc0, reg,
                              uart, data, sizeof(*data), QT2_USB_TIMEOUT);
-       if (ret < sizeof(*data)) {
+       if (ret < (int)sizeof(*data)) {
                if (ret >= 0)
                        ret = -EIO;
        }
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 2083c267787b..0900b47b5f57 100644
--- a/drivers/usb/serial/ssu100.c
+++ b/drivers/usb/serial/ssu100.c
@@ -104,7 +104,7 @@ static inline int ssu100_getregister(struct usb_device *dev,
        ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
                              QT_SET_GET_REGISTER, 0xc0, reg,
                              uart, data, sizeof(*data), 300);
-       if (ret < sizeof(*data)) {
+       if (ret < (int)sizeof(*data)) {
                if (ret >= 0)
                        ret = -EIO;
        }
-- 
2.17.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html