> -----Original Message----- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年5月7日 23:59 > To: Jun Li <jun...@nxp.com> > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; cw00.c...@samsung.com; > shufan_...@richtek.com; Peter Chen <peter.c...@nxp.com>; > gso...@gmail.com; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v5 01/14] dt-bindings: connector: add properties for typec > > On Thu, May 03, 2018 at 08:24:41AM +0800, Li Jun wrote: > > Add bingdings supported by current typec driver, so user can pass all > > those properties via dt. > > > > Signed-off-by: Li Jun <jun...@nxp.com> > > --- > > .../bindings/connector/usb-connector.txt | 44 > +++++++++++++++ > > include/dt-bindings/usb/pd.h | 62 > ++++++++++++++++++++++ > > 2 files changed, 106 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/connector/usb-connector.txt > > b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index e1463f1..4b19de6d0 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -15,6 +15,33 @@ Optional properties: > > - type: size of the connector, should be specified in case of USB-A, USB-B > > non-fullsize connectors: "mini", "micro". > > > > +Optional properties for usb-c-connector: > > +- power-role: should be one of "source", "sink" or "dual"(DRP) if > > +typec > > + connector has power support. > > +- try-power-role: preferred power role if "dual"(DRP) can support > > +Try.SNK > > + or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC. > > +- data-role: should be one of "host", "device", "dual"(DRD) if typec > > + connector supports USB data. > > Need to define what are the defaults on these if the properties aren't present > (ideally, those would be the common case)?
If one of above properties isn't present, means the port doesn't have corresponding capability. I think the common case is a port has a specific property value, but it's also possible it doesn't support that function(e.g. a typec port only for power but no data communication), so I use "not present" for this case instead of some default value). Thanks Li Jun > > Rob
