Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
usb-testing
config: i386-randconfig-s0-201815 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb/core/hcd.c:2378:18: error: 'dev' undeclared (first use in this 
>> function)
     pm_wakeup_event(dev, 0);
                     ^~~
   drivers/usb/core/hcd.c:2378:18: note: each undeclared identifier is reported 
only once for each function it appears in

vim +/dev +2378 drivers/usb/core/hcd.c

  2364  
  2365  /**
  2366   * usb_hcd_resume_root_hub - called by HCD to resume its root hub
  2367   * @hcd: host controller for this root hub
  2368   *
  2369   * The USB host controller calls this function when its root hub is
  2370   * suspended (with the remote wakeup feature enabled) and a remote
  2371   * wakeup request is received.  The routine submits a workqueue request
  2372   * to resume the root hub (that is, manage its downstream ports again).
  2373   */
  2374  void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
  2375  {
  2376          unsigned long flags;
  2377  
> 2378          pm_wakeup_event(dev, 0);
  2379          spin_lock_irqsave (&hcd_root_hub_lock, flags);
  2380          if (hcd->rh_registered) {
  2381                  set_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags);
  2382                  queue_work(pm_wq, &hcd->wakeup_work);
  2383          }
  2384          spin_unlock_irqrestore (&hcd_root_hub_lock, flags);
  2385  }
  2386  EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
  2387  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to