On 04/13/2018 08:42 PM, Jun Li wrote:
Hi Guenter,
-----Original Message-----
From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck
Sent: 2018年4月14日 11:03
To: Jun Li <jun...@nxp.com>
Cc: gre...@linuxfoundation.org; robh...@kernel.org;
heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com;
yueyao....@gmail.com; linux-usb@vger.kernel.org; dl-linux-imx
<linux-...@nxp.com>
Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-*
properties
On 04/13/2018 04:31 PM, Jun Li wrote:
-----Original Message-----
From: Guenter Roeck [mailto:li...@roeck-us.net]
Sent: 2018年4月14日 0:04
To: Jun Li <jun...@nxp.com>
Cc: gre...@linuxfoundation.org; robh...@kernel.org;
heikki.kroge...@linux.intel.com; hdego...@redhat.com;
rmf...@gmail.com; yueyao....@gmail.com; linux-usb@vger.kernel.org;
dl-linux-imx <linux-...@nxp.com>
Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove
max-sink-* properties
On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote:
Remove max-sink-* properties since they are deprecated.
Reviewed-by: Rob Herring <r...@kernel.org>
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Li Jun <jun...@nxp.com>
---
Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------
1 file changed, 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
index 472facf..6087dc7 100644
--- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
+++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
@@ -6,12 +6,6 @@ Required properties :
- interrupts : Interrupt specifier
Optional properties :
-- fcs,max-sink-microvolt : Maximum voltage to negotiate when
configured as
sink
-- fcs,max-sink-microamp : Maximum current to negotiate when
configured
as sink
-- fcs,max-sink-microwatt : Maximum power to negotiate when
configured as
sink
- If this is less then max-sink-microvolt *
- max-sink-microamp then the configured current will
- be clamped.
Is it acceptable to just remove properties ?
What else you suggest I should do? also add document here to explain
why remove them?
I would suggest to either wait for Rob's feedback or check how other bindings
handle deprecated properties.
Rob already reviewed this patch and gave his reviewed-by[1], you can see it in
the
patch tags.
[1]https://www.spinics.net/lists/devicetree/msg221601.html
Ah, ok. Guess you are ok then. Sorry, should have noticed.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
