Hi
> -----Original Message-----
> From: Mats Karrman [mailto:[email protected]]
> Sent: 2018年3月15日 23:54
> To: Jun Li <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> dl-linux-imx <[email protected]>
> Subject: Re: [PATCH v3 02/12] dt-bindings: usb: add documentation for typec
> port controller(TCPCI)
>
> Hi,
>
> On 2018-03-13 10:34, Li Jun wrote:
>
> > TCPCI stands for typec port controller interface, its implementation
> > has full typec port control with power delivery support, it's a
> > standard i2c slave with GPIO input as irq interface, detail see spec
> > "Universal Serial Bus Type-C Port Controller Interface Specification
> > Revision 1.0, Version 1.1"
> >
> > Signed-off-by: Li Jun <[email protected]>
> > ---
> > change for v3:
> > - change compatible string from "usb,tcpci" to be
> > "usb-tcpci,chip-specific-string", update example of it.
> >
> > .../devicetree/bindings/usb/typec-tcpci.txt | 36
> ++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> > b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> > new file mode 100644
> > index 0000000..fe7d2ff
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> > @@ -0,0 +1,36 @@
> > +TCPCI(Typec port cotroller interface) binding
> > +---------------------------------------------
> > +
> > +Required properties:
> > +- compatible: should be "usb-tcpci,chip-specific-string".
> > +- reg: the i2c slave address of typec port controller device.
> > +- interrupt-parent: the phandle to the interrupt controller which provides
> > + the interrupt.
> > +- interrupts: interrupt specification for tcpci alert.
> > +
> > +Required sub-node:
> > +- connector: The "usb-c-connector" attached to the tcpci chip, the
> > +bindings
> > + of connector node are specified in
> > + Documentation/devicetree/bindings/connector/usb-connector.txt
> > +
> > +Example:
> > +
> > +ptn5110@50 {
> > + compatible = "usb-tcpci,ptn5110";
> > + reg = <0x50>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > +
> > + usb_con: connector {
> > + compatible = "usb-c-connector";
> > + label = "USB-C";
> > + port-type = "dual";
> > + try-power-role = "sink"
> > + source-pdos = <0x380190c8>;
> > + sink-pdos = <0x380190c8 0x3802d0c8>;
> > + max-sink-microvolt = <9000>;
> > + max-sink-microamp = <2000>;
> > + max-sink-microwatt-hours = <18000>;
> > + op-sink-microwatt-hours = <9000>;
>
> Values should change with suffix, e.g. 9000mV = 9000000uV
>
Yes, thanks for pointing this out, I will update in v4.
Jun
> // Mats
>
> > + };
> > +};
> >
N�����r��y����b�X��ǧv�^�){.n�+����{������^n�r���z���h�����&�� �G���h�(�階�ݢj"���m������z�ޖ���f���h���~�m�
