On 6 November 2012 01:45, Ming Lei <ming....@canonical.com> wrote:
> This patch fixes memory leak in smsc95xx_suspend.

Good spot, thanks!

Note that check_warn_return just above your kfree can cause early
return in the error case, which would still leak filter_mask, so we
might want to explicitly expand that instance of the helper macro.

> Also, it isn't necessary to bother mm to allocate 8bytes/16byte,
> and we can use stack variable safely.

Acked-By: Steve Glendinning <steve.glendinn...@shawell.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to