Hi,

I was looking at the driver and saw potential problems.

As pre_reset() and suspend() are identical there is a problem with
resetting.

        /* kill all URBs and delayed work that might still be pending */
        usb_kill_urb(ucs->urb_ctrl);
        usb_kill_urb(ucs->urb_int_in);
        del_timer_sync(&ucs->timer_ctrl);
        del_timer_sync(&ucs->timer_atrdy);
        del_timer_sync(&ucs->timer_cmd_in);
        del_timer_sync(&ucs->timer_int_in);
        cancel_work_sync(&ucs->int_in_wq);

You are calling cancel_work_sync(). However int_in_work() may itself
be resetting the device. This seems to be a situation that should be avoided.

        Regards
                Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to