On Tue, 9 Oct 2012, Greg KH wrote:

> Ugh, that "simple" patch has turned up more bugs in drivers than
> anything I know of in recent history.

It would be a good idea for someone to audit all the serial drivers.  
The basic idea is simple:

        The .port_probe and .port_remove methods should handle
        anything connected with an individual port.

        The .probe, .attach, .disconnect, and .release methods
        should handle things associated with the entire device,
        not with any particular port.  They definitely should
        not call usb_get_serial_port_data().

It wouldn't be surprising to find that several of the drivers violate
these rules.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to