On Tue, Sep 18, 2012 at 09:03:01AM +0200, Rene Buergel wrote: > This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and > adapts Makefiles and Kconfigs > > Signed-off-by: René Bürgel <rene.buer...@sohard.de> > --- > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 1bfcd02..1c63b54 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -244,3 +244,7 @@ config USB_YUREX > To compile this driver as a module, choose M here: the > module will be called yurex. > > +config USB_EZUSB > + bool "Functions for loading firmware on EZUSB chips"
This should be a tristate so the ezusb code can be a module on it's own. Or I think it should, as it is, I get the following build errors with this patch applied: ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/whiteheat.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial/keyspan_pda.ko] undefined! ERROR: "ezusb_fx1_ihex_firmware_download" [drivers/usb/serial/keyspan.ko] undefined! Which is odd, as I thought those functions were exported. So something is wrong here with this patch, I've applied the first 2, care to redo this one so it works properly? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
