On 08/17/2012 11:10 AM, Roland Stigge wrote:
Also, since this device is a single controller in the LPC32xx SoC, I
would keep it until some other silicon uses several of this IP core
(which I doubt), at which point we would probably still keep the (global
static) controller and memcpy it to a dynamically allocated struct.
Sounds reasonable?
Yes it does.
Some minor things:
- please use to_udc() in start then
- would it make sense to use platform_get_drvdata() in
lpc32xx_udc_shutdown() ?
- could you please remove struct usb_endpoint_descriptor from struct
lpc32xx_ep? It has been removed a while back from other drivers.
Your proc_udc_show() makes me sad. Felipe, didn't we want something
like this in udc-core?
Thanks,
Roland
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
