Thanks Felipe! I'll send it off to Greg today. Sarah Sharp
On Tue, Aug 07, 2012 at 02:10:03PM +0300, Felipe Balbi wrote: > drivers/usb/host/xhci.c:1826:14: warning: symbol 'xhci_get_block_size' was > not declared. Should it be static? > drivers/usb/host/xhci.c:1844:14: warning: symbol 'xhci_get_largest_overhead' > was not declared. Should it be static? > drivers/usb/host/xhci-ring.c:2304:36: warning: context imbalance in > 'handle_tx_event' - unexpected unlock > drivers/usb/host/xhci-hub.c:425:6: warning: symbol > 'xhci_set_remote_wake_mask' was not declared. Should it be static? > > Signed-off-by: Felipe Balbi <[email protected]> > --- > drivers/usb/host/xhci-hub.c | 2 +- > drivers/usb/host/xhci-ring.c | 2 ++ > drivers/usb/host/xhci.c | 5 +++-- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c > index 74bfc86..5575402 100644 > --- a/drivers/usb/host/xhci-hub.c > +++ b/drivers/usb/host/xhci-hub.c > @@ -422,7 +422,7 @@ void xhci_set_link_state(struct xhci_hcd *xhci, __le32 > __iomem **port_array, > xhci_writel(xhci, temp, port_array[port_id]); > } > > -void xhci_set_remote_wake_mask(struct xhci_hcd *xhci, > +static void xhci_set_remote_wake_mask(struct xhci_hcd *xhci, > __le32 __iomem **port_array, int port_id, u16 wake_mask) > { > u32 temp; > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > index 8275645..3bc1224 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -1995,6 +1995,8 @@ static int process_bulk_intr_td(struct xhci_hcd *xhci, > struct xhci_td *td, > */ > static int handle_tx_event(struct xhci_hcd *xhci, > struct xhci_transfer_event *event) > + __releases(&xhci->lock) > + __acquires(&xhci->lock) > { > struct xhci_virt_device *xdev; > struct xhci_virt_ep *ep; > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 7648b2d..081c49e 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -1823,7 +1823,7 @@ static void xhci_finish_resource_reservation(struct > xhci_hcd *xhci, > xhci->num_active_eps); > } > > -unsigned int xhci_get_block_size(struct usb_device *udev) > +static unsigned int xhci_get_block_size(struct usb_device *udev) > { > switch (udev->speed) { > case USB_SPEED_LOW: > @@ -1841,7 +1841,8 @@ unsigned int xhci_get_block_size(struct usb_device > *udev) > } > } > > -unsigned int xhci_get_largest_overhead(struct xhci_interval_bw *interval_bw) > +static unsigned int > +xhci_get_largest_overhead(struct xhci_interval_bw *interval_bw) > { > if (interval_bw->overhead[LS_OVERHEAD_TYPE]) > return LS_OVERHEAD; > -- > 1.7.12.rc0 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
