Hi Bhupesh,

Thanks for the patch.

On Thursday 26 July 2012 10:42:49 Bhupesh Sharma wrote:
> In case of super-speed descriptors for a UVC device, the `bEndpointAddress`
> of the video control endpoint (interrupt endpoint), was not correctly
> assigned and hence it was initialized with a default value of 0x80. This
> caused the enumeration of a super-speed UVC device on a Windows7 host
> machine to fail.
> 
> This patch fixes this issue and the UVC device enumeration has been
> tested on a Windows7 host machine.

This looks good, but is superseded by my "usb: gadget/uvc: Merge the SS/HS/FS 
status endpoint descriptors" patch (which should have been named "usb: 
gadget/uvc: Merge the SS/HS/FS control endpoint descriptors", I'll fix that).

> Signed-off-by: Bhupesh Sharma <bhupesh.sha...@st.com>
> ---
>  drivers/usb/gadget/f_uvc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c
> index 2a8bf06..70fa610 100644
> --- a/drivers/usb/gadget/f_uvc.c
> +++ b/drivers/usb/gadget/f_uvc.c
> @@ -703,6 +703,10 @@ uvc_function_bind(struct usb_configuration *c, struct
> usb_function *f) uvc_ss_streaming_ep.bEndpointAddress =
>                               uvc_fs_streaming_ep.bEndpointAddress;
> 
> +             /* Video Control endpoint */
> +             uvc_ss_control_ep.bEndpointAddress =
> +                             uvc_fs_control_ep.bEndpointAddress;
> +
>               /* Copy descriptors. */
>               f->ss_descriptors = uvc_copy_descriptors(uvc, USB_SPEED_SUPER);
>       }

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to