On Thu, 2 Aug 2012, Lan Tianyu wrote:

> >> 3)Root-hub set port's DeviceRemovable flag where PortIsConnectable and
> >> UserVisible are clear.
> >
> > Set DeviceRemovable whenever UserVisible is set.  Right now ehci-hcd
> > and uhci-hcd always set DeviceRemovable to 0.
> 
> UserVisible is got from ACPI and permanent. So we only need set once when
> the port binding with acpi.

However DeviceRemovable is filled in dynamically, whenever the
Get-Hub-Descriptor request is received by a host controller driver.

> >> 4)Add QUIRK_POWEROFF_MORPHS flags for those devices which retain
> >> important settings across a reset but lose them when power is removed.
> >
> > This flag doesn't care about resets.  It applies to any device which
> > loses important settings when bus power is removed.
> >
> Since it applies to any devices, how about renaming QUIRK_POWEROFF?
> not all device morphs.

Okay, you could name it that.  And you could change QUIRK_RESET_MORPHS 
to QUIRK_RESET.  Unless Oliver objects.  :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to