On Mon, 9 Jul 2012, Eric Ding wrote: > The patch compiles cleanly and seems to work here (video and audio) > without any problem. One question, though: is it really necessary to do > the reset in this block "in case the device was just resumed"? > > I think you said before that this is to guard against the possibility > that the device was already autoresumed before this code is called, but > usb_enable_autosuspend() isn't called until the end of uvc_probe(); > doesn't that mean that your scenario wouldn't ever happen? As long as > the quirk is set before usb_enable_autosuspend() is called, isn't a > precautionary reset unnecessary?
Maybe so. It's always possible for udev or the user to enable autosuspend in the absence of a driver. I admit the scenario is unlikely. On the other hand, as Oleksij pointed out, we could run into problems if the webcam's sound interface is used without the video interface. If uvcvideo never binds to it then the quirk wouldn't get set. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
