On Wed, Jul 04, 2012 at 09:18:04AM +0200, Hans de Goede wrote:
> We don't support sg for isoc transfers, enforce this.
> 
> Signed-off-by: Hans de Goede <hdego...@redhat.com>
> Acked-by: Alan Stern <st...@rowland.harvard.edu>
> ---
>  drivers/usb/core/hcd.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 140d3e1..3d2f48f 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -1389,7 +1389,12 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, 
> struct urb *urb,
>           && !(urb->transfer_flags & URB_NO_TRANSFER_DMA_MAP)) {
>               if (hcd->self.uses_dma) {
>                       if (urb->num_sgs) {
> -                             int n = dma_map_sg(
> +                             int n;
> +
> +                             /* We don't support sg for isoc transfers ! */
> +                             BUG_ON(usb_endpoint_xfer_isoc(&urb->ep->desc));

No, sorry, I will not take new BUG_ON() calls in any drivers.  You just
crashed a machine, and there is no way that a user can recover.  What
are they supposed to do here?  Who are they going to tell to fix the
issue?

I can see a WARN_ON() and then handle the error properly, but don't
crash a box, that's just rude.

I'll take the other 3 patches in this series, but not this one, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to