On Mon, 2008-02-25 at 11:38 -0800, Greg KH wrote: > On Mon, Feb 25, 2008 at 01:32:04PM -0500, Dan Williams wrote: > > On Mon, 2008-02-25 at 03:07 -0500, David Zeuthen wrote: > > > On Sun, 2008-02-24 at 21:18 -0800, Greg KH wrote: > > > > I have no problem exporting a simple sysfs attribute showing if the > > > > device is either CDMA or GSDM. I would think with that, HAL would not > > > > need to keep any kind of tables at all, and then the device info only > > > > has to stay in one place. > > > > > > This would be ideal. IIRC the only reason for keeping the tables was > > > that there was no such attribute. Sounds about right Dan? > > > > Yes, that was correct. > > <side rant> > > It's not like the kernel is immutable people. If you need to work > around something you find strange in the kernel, or the kernel is not > exporting something that you need for userspace to work easier, please > ask the kernel developers! Otherwise we don't know there's an issue at > all. It's not like it is hard to find and get ahold of us... > > > However, we should keep the current HAL > > specification addition for a few reasons: > > > > 1) devices that are only supported by usb-serial; which includes things > > that are not CDMA/GSM modems > > Like what? NO DEVICES THAT ARE MODEMS SHOULD BE USING THE GENERIC > USB-SERIAL DRIVER!!! Do I need to say this again somewhere else? They > should ALL have a "real" usb-serial child driver to allow for proper > flow control, auto-loading of drivers, and the ability to actually send > data at a speed that isn't comparible to RFC 1149. > > > 2) devices that are PCMCIA serial cards (which are matched only on > > class, not the manf IDs necessarily) > > These devices are no longer being manufactured from what I can tell. So > that list should be fixed.
Yeah, that should be fixed. > > 3) previous kernel versions that wouldn't have the magic sysfs attribute > > Sure, but don't go adding new devices to the table, as that would be > wrong. Right; but I want to preserve the ability for distros to ship .fdi files that tag the devices correctly even if the distro isn't using a kernel that contains the new sysfs stuff. > > It would be worth exploring how to do this; but the problem is that > > since there are devices that support both GSM and CDMA, we'd need to > > figure out how to deal with that vs. sysfs-one-value-per-file. We > > shouldn't really call them "GSM" and "CDMA" but use the standards names > > as Marcel correctly pointed out on the HAL list. > > Why not have two files, one that shows up if GSM is supported, one if > CDMA is. Modems that support both would export both. It's up to > userspace to pick which to use, the kernel sure doesn't care. I'd caution against calling them "gsm" and "cdma", hence why we picked the actual standards name for the HAL spec. It's not really about the PHY modulation (since UMTS/HSPA uses 5MHz WCDMA) but it's about what commands the chipset supports through the serial interface, which is defined by the standards the card supports. Should there be another directory for the standards supported under which can be "is-707-a" and "gsm-07.07"/"gsm-07.05"? That seems kind of odd. Dan > Sound reasonable? > > thanks, > > greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
