>>>>> "Greg" == Greg KH <[EMAIL PROTECTED]> writes:
Greg> On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote:
>> This patch adds HCD support for the Cypress c67x00 family of devices.
>>
>> Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]>
Greg> And it doesn't build:
Greg> CC [M] drivers/usb/c67x00/c67x00-hcd.o
Greg> distcc[2413] ERROR: compile
/home/gregkh/.ccache/c67x00-hcd.tmp.mini.2409.i on localhost failed
Greg> drivers/usb/c67x00/c67x00-hcd.c:345: error: redefinition of
'c67x00_hcd_probe'
Greg> drivers/usb/c67x00/c67x00-hcd.h:119: error: previous definition of
'c67x00_hcd_probe' was here
Greg> drivers/usb/c67x00/c67x00-hcd.c:402: error: redefinition of
'c67x00_hcd_remove'
Greg> drivers/usb/c67x00/c67x00-hcd.h:126: error: previous definition of
'c67x00_hcd_remove' was here
Greg> make[2]: *** [drivers/usb/c67x00/c67x00-hcd.o] Error 1
Greg> make[1]: *** [drivers/usb/c67x00] Error 2
Greg> make: *** [_module_drivers/usb] Error 2
Huh, that doesn't make any sense to me. The dumy definitions of
c67x00_hcd_{probe,remove} are protected by an ifndef
CONFIG_USB_C67X00_HCD, and c67x00-hcd.c which contains the real
definitions only gets compiled if CONFIG_USB_C67X00_HCD is
enabled. Could you perhaps provide some more details?
Anyway, the conditional hcd stuff isn't really needed at this point in
the patch series, so I have moved it into patch 4 in the v8 series
I'll post in a minute.
Greg> This is _after_ removing the obviously incorrect usb_disabled()
Greg> function that you included in your .h file.
That was again for conditional hcd/udc support. I have now moved the
check into _hcd_probe() instead.
Greg> I'm going to hold off applying any of these for now, as it
Greg> doesn't look like something is configured properly here.
Could you give the v8 series a try please?
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
