On Saturday 16 February 2008, Alan Cox wrote: > On Sat, 16 Feb 2008 13:22:25 -0800 > David Brownell <[EMAIL PROTECTED]> wrote: > > > On Saturday 16 February 2008, David Brownell wrote: > > > On USB cable disconnect g_serial doesn't hangup the port tty, > > > which results in an endless read on the tty device. With the > > > following patch the read and select behave correctly when > > > the cable is unplugged. > > > > Whoops, maybe not. Doesn't tty_hangup() have a restriction > > that it must be called form task context? > > The hangup method triggers a tasklet so that should be fine.
I seem to have been looking at do_tty_hangup() not tty_hangup()... aargh. OK, patch should be no problem. - Dave - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html