On Sun, 10 Feb 2008, Alan Stern wrote:

> On Sun, 10 Feb 2008, Mike Isely wrote:
> 

   [...]

> 
> While it's clear that your patch didn't cause this, nevertheless the
> fact remains that one should never do DMA to addresses on the stack.  
> While it works okay on x86, there are other architectures on which it
> won't work.  The feature_buffer storage should be allocated
> dynamically, by kmalloc().
> 
> Alan Stern
> 

Understood.  However this patch certainly doesn't make that situation 
any worse than it already was so I hope this doesn't hold up its 
acceptance.  I'll be happy to follow up with another patch which changes 
that to a kmalloc'ed buffer.

  -Mike


-- 
                        |         Mike Isely          |     PGP fingerprint
     Spammers Die!!     |                             | 03 54 43 4D 75 E5 CC 92
                        |   isely @ pobox (dot) com   | 71 16 01 E2 B5 F5 C1 E8
                        |                             |
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to