On Tue, Feb 05, 2008 at 02:12:06PM -0800, David Brownell wrote: > On Wednesday 30 January 2008, Sarah Sharp wrote: > > Hi Dave, > > > > I've been looking at ehci_shutdown() in ehci-hcd.c with increasing > > puzzlement. > > Why shut off port power before attempting to stop the host controller from > > processing the periodic and async schedules? > > That should indeed be done later. In fact it should probably do what > ehci_shutdown() does ... differences being that stop() probably couldn't > avoid the msleep(), if that's even needed, and certainly can't get away > with leaving debris in misbehaving I/O queues. > > Likewise ehci_shutdown() should kill those timers too, so they don't > fire before this kernel stops.
Is ehci_shutdown called in interrupt context? If it is, the watchdog timer can't be disabled because del_timer_sync() can't be called from interrupt context. The HC interrupts can be disabled though. Sarah - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
