On Fri, 1 Feb 2008, Oliver Neukum wrote: > Am Freitag, 1. Februar 2008 16:10:45 schrieb Alan Stern: > > On Fri, 1 Feb 2008, Oliver Neukum wrote: > > > > > Hi, > > > > > > this patch implements autosuspend for USB audio devices. > > > > > @@ -1937,6 +1945,7 @@ static int snd_usb_pcm_close(struct > > > snd_pcm_substream *substream, int direction) > > > subs->interface = -1; > > > } > > > subs->pcm_substream = NULL; > > > + usb_autopm_put_interface(subs->stream->chip->pm_intf); > > > return 0; > > > } > > > > You need to be very careful here. It's illegal to call > > usb_autopm_put_interface() after the disconnect method has returned. > > Please apply this additional patch and retest.
It looks like other parts of the USB audio driver needed the protection provided by your shutdown_lock too, right? So I don't feel too guilty about pointing out that autosuspend needs it... Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
