On Thursday 10 January 2008, Alan Stern wrote: > This patch (as1030) moves a del_timer_sync() call outside the scope of a > spinlock, where it could cause a deadlock, and adds a new > del_timer_sync() call for the new IAA watchdog timer (it was omitted > by mistake). > > Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > CC: David Brownell <[EMAIL PROTECTED]> > > Index: usb-2.6/drivers/usb/host/ehci-hub.c > =================================================================== > --- usb-2.6.orig/drivers/usb/host/ehci-hub.c > +++ usb-2.6/drivers/usb/host/ehci-hub.c > @@ -121,6 +121,8 @@ static int ehci_bus_suspend (struct usb_ > > ehci_dbg(ehci, "suspend root hub\n"); > > + del_timer_sync(&ehci->watchdog); > + del_timer_sync(&ehci->iaa_watchdog);
I'd rather see these go *after* the potential msleep ... in case they have actual work to do. Otherwise, ack. > if (time_before (jiffies, ehci->next_statechange)) > msleep(5); > > @@ -171,7 +173,6 @@ static int ehci_bus_suspend (struct usb_ > } > > /* turn off now-idle HC */ > - del_timer_sync (&ehci->watchdog); > ehci_halt (ehci); > hcd->state = HC_STATE_SUSPENDED; > > - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
