From: Tiwei Bie <tiwei....@antgroup.com>

Remove the declaration of 'err' inside the 'if (timetravel)' block,
as it would otherwise be unavailable outside that block, potentially
leading to uml_rtc_start() returning an uninitialized value.

Fixes: dde8b58d5127 ("um: add a pseudo RTC")
Signed-off-by: Tiwei Bie <tiwei....@antgroup.com>
---
 arch/um/drivers/rtc_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/drivers/rtc_user.c b/arch/um/drivers/rtc_user.c
index 51e79f3148cd..67912fcf7b28 100644
--- a/arch/um/drivers/rtc_user.c
+++ b/arch/um/drivers/rtc_user.c
@@ -28,7 +28,7 @@ int uml_rtc_start(bool timetravel)
        int err;
 
        if (timetravel) {
-               int err = os_pipe(uml_rtc_irq_fds, 1, 1);
+               err = os_pipe(uml_rtc_irq_fds, 1, 1);
                if (err)
                        goto fail;
        } else {
-- 
2.34.1


Reply via email to