On Mon, 14 Apr 2025 16:55:57 +0200
Uros Bizjak <ubiz...@gmail.com> wrote:
> Current minimum required version of binutils is 2.25,
> which supports PAUSE instruction mnemonic.
>
> Replace "REP; NOP" with this proper mnemonic.
>
> No functional change intended.
>
> Signed-off-by: Uros Bizjak <ubiz...@gmail.com>
> Cc: Richard Weinberger <rich...@nod.at>
> Cc: Anton Ivanov <anton.iva...@cambridgegreys.com>
> Cc: Johannes Berg <johan...@sipsolutions.net>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Ingo Molnar <mi...@kernel.org>
> Cc: Borislav Petkov <b...@alien8.de>
> Cc: Dave Hansen <dave.han...@linux.intel.com>
> Cc: "H. Peter Anvin" <h...@zytor.com>
> ---
> arch/x86/um/asm/processor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/asm/processor.h b/arch/x86/um/asm/processor.h
> index 478710384b34..233a7a0d29c9 100644
> --- a/arch/x86/um/asm/processor.h
> +++ b/arch/x86/um/asm/processor.h
> @@ -24,7 +24,7 @@
> /* REP NOP (PAUSE) is a good thing to insert into busy-wait loops. */
> static __always_inline void rep_nop(void)
> {
> - __asm__ __volatile__("rep;nop": : :"memory");
> + __asm__ __volatile__("pause": : :"memory");
> }
>
That only makes sense if you also change the function name.
David
> static __always_inline void cpu_relax(void)
