pagetable_*_ctor all have the same basic implementation. Move the
common part to a helper to reduce duplication.

Acked-by: Dave Hansen <dave.han...@linux.intel.com>
Signed-off-by: Kevin Brodsky <kevin.brod...@arm.com>
---
 include/linux/mm.h | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 1a11f9df5c2d..065fa9449d03 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -3076,6 +3076,14 @@ static inline bool ptlock_init(struct ptdesc *ptdesc) { 
return true; }
 static inline void ptlock_free(struct ptdesc *ptdesc) {}
 #endif /* defined(CONFIG_SPLIT_PTE_PTLOCKS) */
 
+static inline void __pagetable_ctor(struct ptdesc *ptdesc)
+{
+       struct folio *folio = ptdesc_folio(ptdesc);
+
+       __folio_set_pgtable(folio);
+       lruvec_stat_add_folio(folio, NR_PAGETABLE);
+}
+
 static inline void pagetable_dtor(struct ptdesc *ptdesc)
 {
        struct folio *folio = ptdesc_folio(ptdesc);
@@ -3093,12 +3101,9 @@ static inline void pagetable_dtor_free(struct ptdesc 
*ptdesc)
 
 static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc)
 {
-       struct folio *folio = ptdesc_folio(ptdesc);
-
        if (!ptlock_init(ptdesc))
                return false;
-       __folio_set_pgtable(folio);
-       lruvec_stat_add_folio(folio, NR_PAGETABLE);
+       __pagetable_ctor(ptdesc);
        return true;
 }
 
@@ -3202,13 +3207,10 @@ static inline spinlock_t *pmd_lock(struct mm_struct 
*mm, pmd_t *pmd)
 
 static inline bool pagetable_pmd_ctor(struct ptdesc *ptdesc)
 {
-       struct folio *folio = ptdesc_folio(ptdesc);
-
        if (!pmd_ptlock_init(ptdesc))
                return false;
-       __folio_set_pgtable(folio);
        ptdesc_pmd_pts_init(ptdesc);
-       lruvec_stat_add_folio(folio, NR_PAGETABLE);
+       __pagetable_ctor(ptdesc);
        return true;
 }
 
@@ -3233,18 +3235,12 @@ static inline spinlock_t *pud_lock(struct mm_struct 
*mm, pud_t *pud)
 
 static inline void pagetable_pud_ctor(struct ptdesc *ptdesc)
 {
-       struct folio *folio = ptdesc_folio(ptdesc);
-
-       __folio_set_pgtable(folio);
-       lruvec_stat_add_folio(folio, NR_PAGETABLE);
+       __pagetable_ctor(ptdesc);
 }
 
 static inline void pagetable_p4d_ctor(struct ptdesc *ptdesc)
 {
-       struct folio *folio = ptdesc_folio(ptdesc);
-
-       __folio_set_pgtable(folio);
-       lruvec_stat_add_folio(folio, NR_PAGETABLE);
+       __pagetable_ctor(ptdesc);
 }
 
 extern void __init pagecache_init(void);
-- 
2.47.0


Reply via email to